Add connectdbParams and other connection key-value functions#67
Open
bens wants to merge 1 commit intohaskellari:masterfrom
Open
Add connectdbParams and other connection key-value functions#67bens wants to merge 1 commit intohaskellari:masterfrom
connectdbParams and other connection key-value functions#67bens wants to merge 1 commit intohaskellari:masterfrom
Conversation
bens
force-pushed
the
master
branch
4 times, most recently
from
0e610de to
a35c60e
Compare
Added a `Storable` instance for an equivalent to `PQconninfoOption` and bindings for the functions that use the struct: - PQconnectdbParams - PQconndefaults - PQconninfo - PQconninfoParse - PQconninfoFree Also added some wrappers which do a minimum of conversion to `ByteString`s and make sure memory isn't leaked.
phadej
reviewed
Jul 11, 2025
| conninfoParse :: B.ByteString -- ^ Connection String | ||
| -> IO [ConninfoOption] | ||
| conninfoParse connStr = | ||
| mask_ $ flip runContT pure $ do |
Collaborator
There was a problem hiding this comment.
why mask_. That looks suspicious. But it seems existing stuff is using mask as well, but only when creating something in C-land and wrapping it ForeignPtr. i.e. to avoid memory leaks.
I think here bracket is sufficient. No need to explicitly mask.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
Storableinstance for an equivalent toPQconninfoOptionand bindings for the functions that use the struct:PQconnectdbParamsPQconndefaultsPQconninfoPQconninfoParsePQconninfoFreeAlso added some wrappers which do a minimum of conversion to
ByteStrings and make sure memory isn't leaked.