Skip to content

changes to tested-with field aren't trivial and, hence, are allowed#1506

Open
ulysses4ever wants to merge 1 commit into
haskell:masterfrom
ulysses4ever:patch-4
Open

changes to tested-with field aren't trivial and, hence, are allowed#1506
ulysses4ever wants to merge 1 commit into
haskell:masterfrom
ulysses4ever:patch-4

Conversation

@ulysses4ever
Copy link
Copy Markdown
Contributor

fix #1505, see explanation there

Copy link
Copy Markdown

@leana8959 leana8959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me 👍

@gbaz
Copy link
Copy Markdown
Contributor

gbaz commented Jun 4, 2026

I believe that the issue in #583 was described too abruptly, and the fix made in #598 was the intended behavior. before, hackage rejected files that had a different tested-with as revisions, which broke a workflow that changed that.

now, hackage allows different tested-with as long as it is not the only change made.

i.e. it still prevents a revision of a file that just modifies tested-with, and I think that was by design. On the other hand, I don't think it matters that much to prevent this, except to prevent abuse, which is unlikely (and if it occurs we can revert or just yell at the person). In which case this simplifies things.

So that said @ulysses4ever what's your use case here? do you intend to frequently update cabal files whenever packages are tested with newer ghcs?

@ulysses4ever
Copy link
Copy Markdown
Contributor Author

@gbaz thank you for the context that I missed. My use case is, indeed, to be able to say that my package supports a new GHC without making a release that otherwise isn't required. I'm not sure what "frequently" could mean here but at most it will be as frequent as new GHC releases. Of course, in practice we do actually make releases once in a while, so it will be less frequent than GHC releases in practice.

@gbaz
Copy link
Copy Markdown
Contributor

gbaz commented Jun 5, 2026

Since each revision has a long-term effect on the size of the index-01 tarball, I think the intent was to not allow this. I'm not sure where I fall on this issue, but its worth thinking through.

@gbaz
Copy link
Copy Markdown
Contributor

gbaz commented Jun 5, 2026

Arguably the (eventual) right design would be to have something like "tested with" but that was not part of the cabal file and instead something that could be modified just in the hackage server store, so without the unfortunate knock-on effects...

On the other hand, I think the amount of people who will be doing this sort of revision will be negligible in the long run, and the ultimate effect on tarball size small.

@ulysses4ever
Copy link
Copy Markdown
Contributor Author

Having it as a part of hackage-server metadata sounds reasonable at first but then we get two pieces of data with the same semantics that will always be divergent. Kinda like what we have with the notion of maintainer, which has produced a lot of confusion. I'd prefer to avoid repeating this mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow changing tested-with in revisions (redux)

4 participants