Skip to content

Don't use braces in fgl.cabal to allow building with MicroHs#116

Merged
athas merged 1 commit into
haskell:masterfrom
konsumlamm:patch-1
Dec 22, 2025
Merged

Don't use braces in fgl.cabal to allow building with MicroHs#116
athas merged 1 commit into
haskell:masterfrom
konsumlamm:patch-1

Conversation

@konsumlamm
Copy link
Copy Markdown
Contributor

MicroHs: https://github.com/augustss/MicroHs

I can add a MicroHs action to the CI if you want, but it might either become outdated (if we pin the MicroHs version) or fail sometimes (when using the latest version). In any case, I also plan to build fgl in the MicroHs CI.

@athas
Copy link
Copy Markdown
Contributor

athas commented Dec 22, 2025

I did not even know that cabal supported braces. I'm more of a custodian than a real maintainer, but I see no reason not to do this.

Is it possible to remove braces via a Hackage revision? It seems a little awkward to do an entire release just for this.

@konsumlamm
Copy link
Copy Markdown
Contributor Author

Is it possible to remove braces via a Hackage revision? It seems a little awkward to do an entire release just for this.

It should be possible, however I'm not sure if MicroCabal actually considers revisions. cc @augustss
This isn't urgent though, so I wouldn't mind waiting a bit for a new release until enough changes have accumulated.

@augustss
Copy link
Copy Markdown

MicroCabal ignores version numbers. It uses a consistent set of packages as defined by Stackage.

@konsumlamm
Copy link
Copy Markdown
Contributor Author

konsumlamm commented Dec 22, 2025

MicroCabal ignores version numbers. It uses a consistent set of packages as defined by Stackage.

But which .cabal file does it use? The one that was originally uploaded or the revised version?
For context: The issue here is that MicroCabal can't parse the current .cabal file.

@augustss
Copy link
Copy Markdown

It uses the version number obtained from stackage to form the URL for download from Hackage.

I think we can tweak the MicroCabal parser to accept braces.

@konsumlamm
Copy link
Copy Markdown
Contributor Author

It uses the version number obtained from stackage to form the URL for download from Hackage.

If I understand correctly, that means that it doesn't use the revised .cabal file, so a revision wouldn't fi the problem.

@athas
Copy link
Copy Markdown
Contributor

athas commented Dec 22, 2025

I think Stackage includes revisions.

@athas
Copy link
Copy Markdown
Contributor

athas commented Dec 22, 2025

I don't know why CI will not run, but this change is obviously harmless.

@athas athas merged commit 1eae453 into haskell:master Dec 22, 2025
0 of 11 checks passed
@Bodigrim
Copy link
Copy Markdown

I think we can tweak the MicroCabal parser to accept braces.

Even Cabal proper would rather not to deal with brace syntax, so cleaning them up is a good thing anyway.

@konsumlamm konsumlamm deleted the patch-1 branch December 23, 2025 10:51
@konsumlamm
Copy link
Copy Markdown
Contributor Author

It uses the version number obtained from stackage to form the URL for download from Hackage.

If I understand correctly, that means that it doesn't use the revised .cabal file, so a revision wouldn't fi the problem.

MicroCabal unfortunately still uses the old .cabal file, however installing via git now works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants