Fix for mismatch # of parameters with importSupertask in the User API#1102
Open
matt-moses wants to merge 1 commit intohashtopolis:masterfrom
Open
Fix for mismatch # of parameters with importSupertask in the User API#1102matt-moses wants to merge 1 commit intohashtopolis:masterfrom
matt-moses wants to merge 1 commit intohashtopolis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for mismatch # of parameters with importSupertask in the User API. I'm not super familiar with the codebase still so please review and let me know if there is a more correct fix.
https://github.com/hashtopolis/server/blob/master/src/inc/utils/SupertaskUtils.class.php#L362 and
https://github.com/hashtopolis/server/blob/master/src/inc/user-api/UserAPISupertask.class.php#L114C21-L121C41
Also, some documentation updates. What is the process for rebuilding the PDF? Can someone help with that please?
Thanks for a great tool!