Skip to content

FE-1454: add sort menu to ds - #9251

Merged
alex-e-leon merged 17 commits into
mainfrom
FE-1454-add-sort-menu-to-ds
Aug 20, 2026
Merged

FE-1454: add sort menu to ds#9251
alex-e-leon merged 17 commits into
mainfrom
FE-1454-add-sort-menu-to-ds

Conversation

@alex-e-leon

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Add SortMenu component to DS

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview Aug 20, 2026 11:49am
hashdotdesign-tokens Ready Ready Preview Aug 20, 2026 11:49am
petrinaut Ready Ready Preview Aug 20, 2026 11:49am
petrinaut-docs Ready Ready Preview Aug 20, 2026 11:49am

@cursor

cursor Bot commented Aug 19, 2026

Copy link
Copy Markdown

PR Summary

Cursor Bugbot is generating a summary for commit a8c7446. Configure here.

@github-actions github-actions Bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/apps > hash.design Affects the `hash.design` design site (app) labels Aug 19, 2026
@github-actions github-actions Bot added the area/infra Relates to version control, CI, CD or IaC (area) label Aug 19, 2026
Comment thread libs/@hashintel/ds-components/src/components/Filter/sort-menu.tsx
Comment thread libs/@hashintel/ds-components/src/components/Filter/sort-menu.tsx
lunelson
lunelson previously approved these changes Aug 20, 2026

@lunelson lunelson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Small bug: the direction of the icon in the trigger vs the direction in the menu, are inverted on this demo:

Image

@alex-e-leon

alex-e-leon commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Looks nice! Small bug: the direction of the icon in the trigger vs the direction in the menu, are inverted on this demo:

Image

The logic was actually correct, the issue is that the ascending A-Z sort icon points down (because z is at the bottom) but an ascending arrow points up - can see how if not treated carefully though this could definitely trip users up. I've switched the example to remove the confusion though

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 86f7562. Configure here.

@alex-e-leon
alex-e-leon added this pull request to the merge queue Aug 20, 2026
Merged via the queue into main with commit 1017a67 Aug 20, 2026
65 of 67 checks passed
@alex-e-leon
alex-e-leon deleted the FE-1454-add-sort-menu-to-ds branch August 20, 2026 12:42
@hash-release hash-release Bot mentioned this pull request Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants