BE-269: HashQL: Move PreInline out into Canonicalization pass

[indietyp]

🌟 What is the purpose of this PR?

This PR refactors the MIR optimization pipeline by extracting the canonicalization logic from PreInline into a reusable Canonicalization pass. This improves code organization and enables the same optimization sequence to be used in multiple contexts.

🔍 What does this change?

• Extracts the canonicalization logic from PreInline into a new Canonicalization pass
• Makes PreInline a thin wrapper around Canonicalization with pre-inlining specific configuration
• Improves the Changed enum's implementation with optimized bitwise operations
• Adds a new overlay method to GlobalTransformState to combine results from multiple passes
• Adds a Miri test command for the changed_bitor functionality

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

• does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

• are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

• do not affect the execution graph

🛡 What tests cover this?

• Added a Miri test for the changed_bitor functionality
• Existing MIR optimization tests cover the refactored functionality

[cursor]

PR Summary

Introduces a reusable MIR canonicalization driver and refactors pre-inlining to use it, plus small infrastructure and perf tweaks.

• Adds transform/canonicalization.rs implementing Canonicalization with configurable max_iterations and fixpoint orchestration of AR/IS/FS-CP/DSE/CFG
• Rewrites PreInline as a thin wrapper around Canonicalization (configured with max_iterations: 8)
• Exposes Canonicalization and CanonicalizationConfig in transform/mod.rs
• Optimizes Changed by adding from_u8_unchecked, inlining BitOr/BitOrAssign, and using unchecked unreachable for better vectorization
• Adds GlobalTransformState::overlay to merge per-pass results and uses it in Canonicalization::run
• package.json: adds test:miri script for changed_bitor

^{Written by Cursor Bugbot for commit 0a15246. This will update automatically on new commits. Configure here.}

[indietyp]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• BE-271: HashQL: Implement PostInline pass #8240
• BE-269: HashQL: Move PreInline out into Canonicalization pass #8239 👈 (View in Graphite)
• BE-268: HashQL: Rename PreInlining to PreInline for consistency #8238
• BE-270: HashQL: Optimize empty tuples to unit constants in MIR #8237
• BE-197: Implement MIR inline pass for HashQL #8236
• BE-267: Use bump scopes instead of full resets across transformation passes #8234
• BE-266: HashQL: Implement PreInlining pass for MIR optimization #8233
• BE-265: HashQL: Make CopyPropagation aware of local re-assignments #8231
• BE-264: HashQL: Rename SROA to ForwardSubstitution for better semantic clarity #8230
• BE-263: HashQL: add body! macro for declarative MIR construction in tests #8229
• BE-261: HashQL: Implement Administrative Reduction pass for MIR #8227
• BE-262: HashQL: Do not intern empty slices #8223
• BE-260: HashQL: Switch to bump allocator with scoping support #8218
• BE-259: HashQL: Add benchmarks for type system operations #8216
• BE-227: HashQL: Implement call graph analysis for MIR #8214
• BE-258: HashQL: Add Changed enum to track MIR transformation pass modifications #8210
• BE-255: HashQL: Implement Copy Propagation (CP) pass for MIR #8207
• BE-231: HashQL: Add InstSimplify pass for MIR instruction simplification and constant folding #8206
• BE-254: Add CodSpeed benchmarking for HashQL MIR transformation passes #8204
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[augmentcode]

🤖 Augment PR Summary

Summary: Refactors the HashQL MIR optimization pipeline by extracting the canonicalization fixpoint logic into a reusable pass.

Changes:

• Introduces a new Canonicalization global transform pass with a configurable iteration limit.
• Reworks PreInline into a thin wrapper around Canonicalization (pre-inlining tuned config).
• Optimizes Changed bitwise OR by using an unchecked discriminant conversion for better codegen/vectorization.
• Adds GlobalTransformState::overlay to merge per-pass/per-iteration change tracking into a single state.
• Wires the new module export and adds a test:miri script for the changed_bitor test.

Technical Notes: Canonicalization runs a pre-pass (CP+CFG) and then iterates AR → IS → (FS/CP) → DSE → CFG until fixpoint or max_iterations.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

[codspeed-hq]

CodSpeed Performance Report

Merging #8239 will not alter performance

_{Comparing bm/be-269-hashql-move-out-most-of-preinline-into-a-canonicalization (0a15246) with bm/be-268-hashql-rename-preinlining-to-preinline (6603ad7)}

Summary

✅ 17 untouched

[codecov]

Codecov Report

❌ Patch coverage is 94.85714% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.96%. Comparing base (6603ad7) to head (0a15246).

Files with missing lines	Patch %	Lines
.../hashql/mir/src/pass/transform/canonicalization.rs	95.54%	5 Missing and 2 partials ⚠️
libs/@local/hashql/mir/src/pass/mod.rs	81.81%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@                                 Coverage Diff                                  @@
##           bm/be-268-hashql-rename-preinlining-to-preinline    #8239      +/-   ##
====================================================================================
+ Coverage                                             64.94%   64.96%   +0.01%     
====================================================================================
  Files                                                   735      736       +1     
  Lines                                                 62982    63019      +37     
  Branches                                               3677     3680       +3     
====================================================================================
+ Hits                                                  40906    40939      +33     
- Misses                                                21597    21600       +3     
- Partials                                                479      480       +1     

Flag	Coverage Δ
rust.hashql-compiletest	46.65% <ø> (ø)
rust.hashql-mir	89.68% <94.85%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.