optional mount path for approle #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
No test as I don't see custom path testing in |
Contributor
Author
|
Hello, is it possible to have a review please ? as the change is very small, it should be fast :) |
Contributor
|
Hi there! We are definitely happy to take a look at this PR! However, our team has inherited this project and we are currently working on ironing out issues with the CI & automated tests. Once we have those fixed we'll be able to review the PRs and take changes. |
Contributor
Author
|
Hello, some news maybe ? |
|
Hi there |
chrisarcand
previously approved these changes
Feb 4, 2026
beekus
previously approved these changes
Feb 4, 2026
beekus
previously approved these changes
Feb 4, 2026
Adds optional mount parameter to approle() method to support AppRole authentication against non-default mount points. Usage: # Default mount point Vault.auth.approle(role_id, secret_id) # Custom mount point Vault.auth.approle(role_id, secret_id, mount: "my-approle") The implementation uses an options hash (mount:) to maintain consistency with other auth methods like userpass and ldap, and to allow for future extensibility. Fully backward compatible - defaults to 'approle' mount. Changes: - Updated approle() to accept options hash with :mount parameter - Fixed deprecated JSON.fast_generate to JSON.generate - Added integration test for custom mount path - Added documentation examples for both default and custom mounts - Updated CHANGELOG Co-authored-by: Laurent Lafage <laurent.lafage@fr.clara.net>
beekus
approved these changes
Feb 4, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually the path for an approle is fixed in code:"/v1/auth/approle/login".
This PR add the possibility to support customizable path, for example, "/v1/auth/my_approle/login"