Conversation
Signed-off-by: adrian <adrian@io.builders>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| modifier validateFactor(uint256 _factor) virtual; | ||
| } | ||
| // solhint-disable-next-line no-empty-blocks | ||
| abstract contract Modifiers is AdjustBalancesModifiers {} |
There was a problem hiding this comment.
Do we really want to keep the inheritance linearization?
We could make it inherit from each corresponding Internal and thus avoid problems of validating who is the last in the inheritance chain so as not to break that linearization. Apart from the possible conflicts we might have in git (as we previously had with Common.sol)
| function _zeroToOne(uint256 _input) internal pure virtual returns (uint256); | ||
| } | ||
| // solhint-disable-next-line no-empty-blocks | ||
| abstract contract Internals is CommonInternals {} |
There was a problem hiding this comment.
Do we really want to keep the inheritance linearization?
We could make it inherit from each corresponding Internal and thus avoid problems of validating who is the last in the inheritance chain so as not to break that linearization. Apart from the possible conflicts we might have in git (as we previously had with Common.sol)
jaime-iobermudez
force-pushed
the
development
branch
from
09d0987 to
2c97663
Compare
4 participants
Description
Type of change
Testing
Node version:
Checklist