DC-2879: Honor rpc_body and rpc_metadata config for gRPC spans - #23
Merged
Merged
Conversation
BaseInstrumentorWrapper was using HTTP data_capture flags (and the wrong body direction flag) when recording rpc.request/response body and metadata. Wire RPC handlers to rpc_body.* and rpc_metadata.* and add a grpc test that asserts bodies/metadata are omitted when disabled in config. Co-authored-by: Cursor <cursoragent@cursor.com>
…ction Add litellm pydantic pytest plugin (same as pythonagent) to SDK CI, and use SpanKind.SERVER when picking the gRPC server span in the rpc_body test. Co-authored-by: Cursor <cursoragent@cursor.com>
prodion23
approved these changes
Sep 8, 2026
thugrock7
approved these changes
Sep 8, 2026
tim-mwangi
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseInstrumentorWrapper was using HTTP data_capture flags (and the wrong body direction flag) when recording rpc.request/response body and metadata. Wire RPC handlers to rpc_body.* and rpc_metadata.* and add a grpc test that asserts bodies/metadata are omitted when disabled in config.