Fix registry:migrate parity gaps and bugs vs hc (#207) - #233
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #207. Brings
harness execute registry:migrateto parity withhc'sregistry migrate, fixing all reported bugs and adding all missing features.Bugs
Run()now talliesStatusFailrecords and joins a%d of %d artifact(s) failed to migrateerror into the returned error, so any failure exits non-zero instead of printing "Migration completed successfully."packageFilterssilently dropped — addedpackageFilterstoConfig(types/selector.go) with per-artifact-type granularity (util/selector_util.go), applied during registry/package traversal.artifactTypenot rejected at config load —validateConfignow callsIsKnownArtifactType, rejecting unknown/mistyped types before any network calls.Missing features
--result-file— writes one JSON-lines record per artifact (status, error, skip reason) to a configurable path, written before the exit-code decision so automation sees the full picture even on failure.--summaryflag — prints condensed Success/Skipped/Failed/Total counts instead of the full per-file table.FileStatnow carries aReasonfield (already_exists,no_content) populated at every skip site, so it's clear why an artifact was skipped.longhelp block toexecute registry:migratecovering an example config, supported artifact types,packageFiltersgranularity, and include/exclude pattern behavior.