fix(app): tighten side-panel right-edge gap - #309
Merged
Conversation
Three changes that together reduce the visible right-side gap: 1. panelRow padding: p-2 (8px all sides) → px-1.5 py-2 (6px horizontal, 8px vertical) + gap-2 → gap-1.5. The 8px inset was visually amplified on the right because macOS traffic lights fill the left edge above the content, while nothing fills the right. Tightening the horizontal inset brings the panels closer to the window edges on both sides. 2. DEFAULT_PANEL_COLUMN_WIDTH: 320 → 330 to match WORK_COLUMN_WIDTH_MIN. The work column container used clampWorkColumnWidth (floor 330) but the side panel aside used the raw stored width (320), leaving a 10px transparent gap inside the container. 3. floorPanelColumnWidth helper: the side panel's panelWidth() memo now floors at WORK_COLUMN_WIDTH_MIN so existing stored widths below 330 can't reintroduce the mismatch. sessionPanelAvailable gap subtraction updated 8 → 6 to match the new gap-1.5.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tightens the right-side gap between the side panel and the window edge. Three changes:
panelRow padding
p-2→px-1.5 py-2, gapgap-2→gap-1.5— reduces the horizontal inset from 8px to 6px on both sides, gap between panels tightened to match.DEFAULT_PANEL_COLUMN_WIDTH320 → 330 — the default was belowWORK_COLUMN_WIDTH_MIN(330), so the work column container (which floors at 330) was wider than the side panel<aside>(which used the raw 320), leaving a 10px transparent gap inside the container.floorPanelColumnWidthhelper — the side panel'spanelWidth()memo now floors atWORK_COLUMN_WIDTH_MINso existing stored widths below 330 can't reintroduce the mismatch.sessionPanelAvailablegap subtraction updated 8 → 6 to match the newgap-1.5.Tests
floorPanelColumnWidth(lifts sub-minimum widths, passes through valid ones)Companion PR: harmoniqs/amicode#875