entitled skills: altissimo + extended piccolissimo in the bundle (#907, ADR-0011 home) - #908
Draft
aarontrowbridge wants to merge 2 commits into
Draft
entitled skills: altissimo + extended piccolissimo in the bundle (#907, ADR-0011 home)#908aarontrowbridge wants to merge 2 commits into
aarontrowbridge wants to merge 2 commits into
Conversation
…set (#907) amicissimo #404 (main 2bcef43) made amicissimo/skills/ the canonical home of the entitled-tier usage skills (piccolissimo, intonatissimo, altissimo — the issmo private packages, per its ADR-0002 boundary test). Until now piccolissimo + intonatissimo were staging-local hand-copies (the #836 drift class) and altissimo existed nowhere. - stage-internal-skills.sh gains a second source: the amicissimo clone, extracted from origin/main via git archive (branch-independent — the clone is fleet-shared and routinely parked on campaign branches), with its own ENTITLED_ALLOWLIST, the same per-skill hash receipts, and a loud SKIP when the clone or skills/ is absent (fleet boxes). - ops/README staging floor 45 -> 46 (altissimo adds one skill). Verified live: all three staged; canonical == staged by sha256; armonissima loop byte-identical (all unchanged receipts).
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…p the staging-script mechanism (#907) REWORK after the ADR-0011 correction (see #907 comment): ADR-0011 (accepted 2026-08-27) rules entitled skills live in packages/extension/skills — 'entitled is a STAGING gate, not a location' — and the boot rsync stages the bundle into the server tree directly, so no second staging source is needed (the amicissimo-sourced git-archive mechanism from the first commit is reverted). - altissimo: NEW entitled skill — the measured solver-tuning doctrine (rho-schedule table incl. the :demand MIXED verdict, churn signature, AL-entry warm-start laws, what-binds facts, honest arm-comparison rules), trimmed to the ADR-0011 content policy (usage ships, internals stay vault). - piccolissimo: extended with matrix-free density routing, the two upstream density-path bugs (#337 sqrt-gamma prescaling, #338 EqualityConstraints endpoint pins), set_state_guess! state warm-starts, the ECO constructor section, Magnus caveat, smoke-budget honesty rail — policy-trimmed. - ops/README: staging floor 45 -> 46 (altissimo adds one).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed after the first commit (the ADR-0011 correction)
The first commit on this branch added a staging-script mechanism sourcing skills from
amicissimo/skills/— built on the premise (from amicissimo #403) thatpiccolissimo/intonatissimowere "staging-local with no canonical home". That premise was wrong, and the branch is reworked:docs/adr/0011-entitled-skill-surface.md, accepted 2026-08-27) ruled this exact question: entitled skills live inpackages/extension/skills/, ship in the vsix, and gate at staging — "entitled is a STAGING gate, not a location". The bundle is the single source of truth, "not an extract pipeline". Hash-verified: the pre-change staged copies were byte-identical to the bundle copies — the boot rsync staged them all along.e9a6922).What this PR now delivers
The content, in its correct home, policy-trimmed:
packages/extension/skills/altissimo/SKILL.md:demandwith its honest MIXED real-problem verdict), the churn signature, the AL-entry warm-start laws, what-binds facts, honest arm-comparison rules. Trimmed to usage per ADR-0011 (no fleet doctrine, no vault pointers, no internal roadmap).packages/extension/skills/piccolissimo/SKILL.mdset_state_guess!state warm-starts, the ECO constructor section (envelope + F_pro≠F_avg traps), the measured Magnus caveat, smoke-budget honesty rail.ops/README.mdContent-policy note for review
Both skills carry
surface: entitled, entitlement: issmo(the exact pattern of the already-shipping piccolissimo skill). Reviewed per ADR-0011's per-line test: constructors, kwargs, knob facts, idioms, measured usage guidance ship; internal trait names, threaded-site architecture detail, fleet compute doctrine, and vault pointers stay in the internal tier (already in the armonissima commons + vault cards). The team-internal deep doctrine (falsified-probe narratives, Prestissimo carry-overs, measurement discipline) is NOT in this PR — it rides the armonissima commons updates.Verification