fix(sidebar): invalidate env cache on workspace change + '+' button opens existing env (#895) - #900
Merged
Merged
Conversation
…pens existing env (#895) Two fixes: 1. onDidChangeWorkspaceFolders now calls invalidateEnvironmentCache() before getRoots(). Without this, adding an environment to the workspace via 'Add to Workspace' left the resolver cache stale — getRoots() returned the environment with source 'resolved' instead of 'workspace', so the context menu kept showing 'Add to Workspace' instead of 'Remove from Workspace'. 2. The '+' button on the Research Environments section header now sends 'add-existing-environment' (folder picker) instead of 'new-environment' (create flow). The '+' should open an existing environment, matching the Research Projects section pattern.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for the Research Environments sidebar section (#895):
invalidateEnvironmentCache()inonDidChangeWorkspaceFolders— the root cause of 'Remove from Workspace' never appearing. When the user clicked 'Add to Workspace' on a resolved environment,updateWorkspaceFolderstriggered the workspace change handler, which calledgetRoots(). But the environment resolver cache was stale, so the project resolution in Pass 2 still returned the old resolved path. The dedup logic saw it first (before the workspace pass could register the same slug), so the environment keptsource: "resolved". Clearing the cache ensures the workspace-folder path wins the dedup.'+' button →
add-existing-environment— the '+' on the environments section header was sendingnew-environment(create flow). It should sendadd-existing-environment(folder picker), matching the Research Projects pattern where '+' adds an existing project.2 updated tests (more precise assertions).