fix(fleet): substitute the tunnel ssh alias in install.sh; refresh deploy receipt - #1034
Merged
Merged
Conversation
…ploy receipt The installer copied the tunnel plist template verbatim, shipping a literal FLEET_SSH_ALIAS placeholder — launchd looped forever on 'could not resolve hostname fleet_ssh_alias' while --check reported all-ok (it never checked the alias). Now: - install.sh (both copies — root + packaged) reads canonical.sshAlias from fleet.json, substitutes it (and the port) into the plist at install, refuses to install a tunnel with no alias, and --check fails loudly on an unsubstituted placeholder or a wrong alias - reconciles the parallel uncommitted fix in the packaged copy (same intent, written twice — the duplicate is now byte-identical to the root) - regenerates the agent-cards deploy receipt for the current 7-card source set (the committed receipt still named the retired autodev/autoresearch cards, flagging agent-cards surfaces stale on every fleet machine)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tools/fleet/install.shcopied the tunnel plist template verbatim, shipping a literalFLEET_SSH_ALIASplaceholder where the ssh alias belongs. Observed live (2026-09-12, MacBook rejoin): launchd retried every 10s onssh: Could not resolve hostname fleet_ssh_aliaswhileinstall.sh --checkreported all ok — the check greps for the keepalive flags and port but never the alias.The user-visible chain: the panel hung "booting" on a dead tunnel → the extension's 10-second "fleet tunnel down — Go Standalone?" dialog fired → the destructive one-tap exit silently reverted
fleet.jsonand ate the rejoin. The placeholder was the root cause; the trap dialog amplified it.Changes
install.sh(both copies — root + packaged, now byte-identical):canonical.sshAliasfromfleet.json--checknow fails on an unsubstituted placeholder or a wrong alias (previously a silent all-ok on a broken tunnel)packages/extension/tools/fleet/install.sh(same intent, written twice, diverging) — the duplicate is now identical to the root copy.packages/extension/agents/.deploy-receipt.jsonfor the current 7-card source set — the committed receipt still named the retiredautodev/autoresearchcards, flagging the agent-cards surfaces stale on every fleet machine.Verification
install.sh --checkgreen on the live MacBook (guard in sync, settings ok, tunnel ok — alias erlich, port 4096)erlichwith the placeholder in the installed plist makes--checkexit 1 with a named failureamico doctor: agent-cards surfacescurrenton both fleet machines that ran the receipt