Repository navigation
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
OSErrorraised bybind_socket, while retaining its type, error number, and traceback.The channel is included in the exception text so callers that log
str(error)see it. This also works on Python 3.10, where exception notes are unavailable.Related Issues / Pull Requests
Type of Change
Checklist
tox).Validation
uv run --no-sync python -m pytest test -q -o addopts='': 500 passed, 131 skipped, 32 subtests passed.uv run --no-sync python -m pytest test/test_socketcan.py -q -o addopts='': 10 passed, 3 skipped, 3 subtests passed after the final change.black --check can/interfaces/socketcan/socketcan.py test/test_socketcan.pyandgit diff --checkpassed.ruff checkreports seven existing diagnostics on lines outside this patch. I did not runtox.