fix(HF-162): scale TEXT percentage formats before rounding - #1776
Tobiadefami wants to merge 2 commits into
Conversation
|
@Tobiadefami thanks for the pull request. No CLA step needed here — our records show you signed the Contributor License Agreement on 2026-07-31. That signature came from our previous signing form and has been carried over, so there is nothing for you to re-sign. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eb63d50. Configure here.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
hyperformula-docs | 0a2fb42 | Commit Preview URL Branch Preview URL |
Sep 17 2026, 10:11 PM |
Performance comparison of head (0a2fb42) vs base (c920375) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1776 +/- ##
========================================
Coverage 97.32% 97.32%
========================================
Files 195 195
Lines 15739 15758 +19
Branches 3390 3468 +78
========================================
+ Hits 15318 15337 +19
+ Misses 421 413 -8
- Partials 0 8 +8
🚀 New features to boost your workflow:
|

Context
How did you test your changes?
Types of changes
Related issues:
Checklist:
Note
Medium Risk
Changes default
TEXToutput for%formats (behavior fix aligned with Excel), which may affect spreadsheets that relied on the old scaling or manual*100workarounds.Overview
Fixes
TEXTpercentage number formats so they match Excel: each active%in the format string multiplies the numeric value by 100 before rounding, soTEXT(0.0123,"0.00%")returns1.23%instead of0.01%.The number-format parser now tokenizes
%, quoted literals, and escapes separately (quoted or escaped%stay literal and do not scale).numberFormatapplies scaling once per percent token, surfaces#VALUE!if scaling overflows, and appends%in the output. CHANGELOG and the Excel compatibility guide document the behavior and note that workarounds that manually multiply by 100 can be removed.Reviewed by Cursor Bugbot for commit 0a2fb42. Bugbot is set up for automated code reviews on this repo. Configure here.