Skip to content

Support private replies in comment widget - #258

Open
ruibaby wants to merge 1 commit into
mainfrom
feat/private-replies
Open

ruibaby wants to merge 1 commit into
mainfrom
feat/private-replies

Conversation

@ruibaby

@ruibaby ruibaby commented Sep 27, 2026

Copy link
Copy Markdown
Member

Summary

  • Show the private option in direct and quoted reply forms when private comments are enabled.
  • Send the selected hidden value when creating a reply.
  • Clarify the privacy and email notification behavior in the form help text and settings.

Validation

  • pnpm -C packages/comment-widget test — 177 tests passed
  • pnpm -C packages exec tsc --noEmit -p comment-widget/tsconfig.json
  • pnpm -C packages exec biome check comment-widget/src/base-form.ts comment-widget/src/reply-form.ts comment-widget/tests/reply-form.browser.test.js
  • JAVA_HOME=$(/usr/libexec/java_home -v 21) ./gradlew build --quiet
  • git diff --check

The browser test covers private and public submissions, quoted replies, and the setting being disabled. Reply creation was not tested against a running Halo instance.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-27T10:12:04.566248Z b440669 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant