Skip to content

Fix PCH visibility settings. #9455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abadams merged 2 commits into from
Sep 21, 2026
+10 −8
Merged

Fix PCH visibility settings. #9455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a65b459
Fix PCH visibility settings.
mcourteaux Sep 18, 2026
c0abf35
Set PCH visibility settings directory-wide instead of per-target.
mcourteaux Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions cmake/HalideTestHelpers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,6 @@ function(add_halide_test TARGET)
set_tests_properties(${TARGET} PROPERTIES PASS_REGULAR_EXPRESSION "Success!")
endif ()

set_target_properties(${TARGET}
PROPERTIES
CXX_VISIBILITY_PRESET hidden
VISIBILITY_INLINES_HIDDEN TRUE
)


if (WITH_SERIALIZATION AND WITH_SERIALIZATION_JIT_ROUNDTRIP_TESTING)
if (NOT Halide_TARGET MATCHES "wasm")
target_compile_definitions(${TARGET} PRIVATE WITH_SERIALIZATION_JIT_ROUNDTRIP_TESTING)
Expand Down
2 changes: 1 addition & 1 deletion src/autoschedulers/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Everything else should be omitted to keep binary size low.
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS OFF)
set(CMAKE_CXX_VISIBILITY_PRESET hidden)
set(CMAKE_VISIBILITY_INLINES_HIDDEN YES)
set(CMAKE_VISIBILITY_INLINES_HIDDEN TRUE)

function(add_autoscheduler)
set(options)
Expand Down
9 changes: 9 additions & 0 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
include(HalideTestHelpers)
include(CheckCXXCompilerFlag)

# All test targets in this directory (and its subdirectories) must be built
# with the same visibility settings, since they reuse a common precompiled
# <Halide.h> header via target_precompile_headers(REUSE_FROM) -- otherwise
# Clang rejects the PCH with "default visibility for functions and variables
# differs in PCH file vs. current file".
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS OFF)
set(CMAKE_CXX_VISIBILITY_PRESET hidden)
set(CMAKE_VISIBILITY_INLINES_HIDDEN TRUE)

# _test_internal is not itself a test; it exists purely so that the other
# test executables below can reuse its precompiled <Halide.h> header via
# target_precompile_headers(REUSE_FROM). HalideTestHelpers depends on this
Expand Down
Loading