Fix name inconsistency in vrms.md file - #8757
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
i. Availability: M-F 6-8PM |
|
i. Availability: M-F 2-9PM |
|
Availability: weekday 9am - 5pm |
There was a problem hiding this comment.
@computarisis nice job 👍
- merging into correct branch
- completed all the tasks requested on the issue
- confirmed changes in my local env
Minor thing:
- I would clean up the visual section of this pull request. I see
at the end of this section. - The first screenshot in "before change" section doesn't have the filter sidebar in the screen so not sure what exactly wants to show. (oh! actually see it's filtered
technologies=mangoDBin the URL 😄 so it's up to you to swap).
Thank you for working on this issue 🥳
Thank you for the observations @Tomomi-K1. As for the screenshots, I wanted to show that you can filter and find VRMS for both prior to the change, but you can't filter for Atlas after the change. |
anthonylo87
left a comment
There was a problem hiding this comment.
HI @computarisis,
Looks good to me.
- Branches are set correctly
- Issue is linked to PR
- No CodeQL alerts
- Changes verified in browser/screenshots look good.
Up to you whether you want to make these changes:
- As @Tomomi-K1 has mentioned, your first image in your "before" section should capture the filter bar, consistent with your second image.
- In the "After" section, you can add a note indicating that it's no longer possible to filter for "MongoDB Atlas", so it's clear why you have three "before" screenshots and only two "after" screenshots.
Fixes #8572
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Note: See that the query is set in the url (even though the sidebar is not shown)
Visuals before changes are applied
Note: MongoDB Atlas, as can be seen on the sidebar, is no longer a filter option. This is because, after removing the line from VRMS, no more projects use it.
Visuals after changes are applied