Add Docker Item to Technologies Section of hellogov.md - #8756
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability : today until 5pm / Th: 9-10am / Fri: 12-2pm ETA: today 3:30pm |
cchrizzle
left a comment
There was a problem hiding this comment.
Hi Kyle,
Looks good to me!
- You added
Dockerin the correct section and in the correct order. - You linked to the original issue.
- You included screenshots showing your changes.
Just a quick note on your branch naming: the example from the docs here put the issue number at the end. I don't know how strict they are with it, but just pointing it out in case. Great job either way though!
yepezjuan
left a comment
There was a problem hiding this comment.
Hey Kyle, PR looks good and properly formatted. I would note for future branches you make to add the issue # at the end of the branch name per HFLA formatting.
Otherwise I see no problem
|
@cchrizzle @yepezjuan thanks for catching that with the formatting with my source/feature branch, if this is an issue with merge team I will fix. I'll be attentive to this in the future. Appreciate the reviews! |
|
Availability : Evenings after 8PM ET ETA: Fri, Aug 28th --Evening |
|
Hi @computarisis! I moved you from the assignees section to the reviewers section that way it'll properly register your review on this PR when you complete it. Happy reviewing! |
Fixes #8657
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Card visuals before changes are applied
Page visuals before changes are applied
Card visuals after changes are applied
Page visuals after changes are applied