feat: add benchmark for fastwebsockets and sockudio-ws. #34
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f23985c8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let mut buf = [0u8; 1024]; | ||
| let n = stream.read(&mut buf).await.unwrap(); | ||
| let (request, _) = handshake::parse_request(&buf[..n]).unwrap().unwrap(); |
There was a problem hiding this comment.
TCP reads are not message-framed, so the first read may return only part of the HTTP upgrade request. In that case handshake::parse_request returns Ok(None), and the immediate unwrap() will panic, making the benchmark flaky on slower or busy systems. Consider buffering and reading until the parser returns Some(request) (or use the crate’s server handshake helper) before proceeding.
Useful? React with 👍 / 👎.
2 participants
No description provided.