Split ingestion validation and materialization modules#293
Merged
Conversation
…-English traversal.","authority":"manual"}
…n paths.","authority":"manual"}
…on paths.","authority":"manual"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_notevalidation non-English traversal into a privatevalidation/non_englishmodule with child-module tests.add_notematerialization into ADD, UPDATE, and NONE owner modules behind the existingmaterializefacade.add_eventmaterialization into ADD, UPDATE, and NONE owner modules behind the existingpersist_extracted_note_decisionfacade.This PR batches three locally verified modularization commits so remote CI runs once for the group.
Validation
Commit: Split add_note validation non-English traversal
cargo make fmt-rustcargo test -p elf-service add_note --lib(8 passed)cargo check -p elf-service --all-targets --all-featurescargo nextest run -p elf-service --lib --all-features add_note(8 passed, 141 skipped)cargo make lint-vstylecargo make lint-rustcargo make fmt-rust-checkgit diff --checkcargo make check-rustcargo make test-rust(399 passed, 92 skipped)cargo make check(399 passed, 92 skipped)Commit: Split add_note materialization paths
cargo make fmt-rustcargo test -p elf-service add_note --lib(10 passed)cargo check -p elf-service --all-targets --all-featurescargo nextest run -p elf-service --lib --all-features add_note(10 passed, 141 skipped)cargo make lint-vstylecargo make lint-rustcargo make fmt-rust-checkgit diff --checkcargo make check-rustcargo make test-rust(401 passed, 92 skipped)cargo make check(401 passed, 92 skipped)Commit: Split add_event materialization paths
cargo make fmt-rustcargo test -p elf-service add_event --lib(3 passed)cargo check -p elf-service --all-targets --all-featurescargo nextest run -p elf-service --lib --all-features add_event(3 passed, 150 skipped)cargo make lint-vstylecargo make lint-rustcargo make fmt-rust-checkgit diff --checkcargo make check-rustcargo make test-rust(403 passed, 92 skipped)cargo make check(403 passed, 92 skipped)