Split live backfill checkpoint helpers#288
Merged
Merged
Conversation
…t helpers after strict validation.","authority":"manual"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
backfill_checkpoint.rs.backfill.rsfocused on env knobs, note_input, SQL state lookups, duplicate detection, async add_note/resume orchestration, and report assembly.Validation:
cargo make fmt-rustcargo nextest run -p elf-eval --all-targets --all-features backfill_checkpoint(4 passed)cargo make lint-vstylecargo make fmt-rust-checkgit diff --checkcargo make check-rustcargo make lint-rustcargo make test-rust(390 passed, 92 skipped)cargo make check(390 passed, 92 skipped)Review: