Skip to content

Split trace compare analysis helpers#285

Merged
yvette-carlisle merged 1 commit into
mainfrom
xy/split-trace-compare-analysis
Jun 29, 2026
Merged

Split trace compare analysis helpers#285
yvette-carlisle merged 1 commit into
mainfrom
xy/split-trace-compare-analysis

Conversation

@yvette-carlisle

Copy link
Copy Markdown
Member

Summary

  • Split pure trace compare analysis helpers into trace_compare/analysis.rs.
  • Kept trace_compare.rs focused on async entrypoint, DB fetch, replay orchestration, and trace assembly.
  • Added focused tests for stage deltas, attribution, invalid snapshot fallback, and valid nil UUID snapshot fallback.

Validation

  • cargo make fmt-rust
  • cargo make check-rust
  • cargo make fmt-rust-check
  • git diff --check
  • cargo make lint-vstyle
  • cargo nextest run -p elf-eval --all-targets --all-features trace_compare::analysis (6 passed)
  • cargo make lint-rust
  • cargo make test-rust (385 passed, 92 skipped)
  • cargo make check (385 passed, 92 skipped)

Review

  • Scout selected trace compare analysis as the next focused modularization boundary.
  • Skeptic passed after the nil UUID fallback coverage gap was resolved.

…helpers after strict validation.","authority":"manual"}
@yvette-carlisle yvette-carlisle merged commit ee0a168 into main Jun 29, 2026
12 checks passed
@yvette-carlisle yvette-carlisle deleted the xy/split-trace-compare-analysis branch June 29, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant