Split docs source capture helpers#279
Merged
Merged
Conversation
…pers after strict validation.","authority":"manual"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/source_capture/helpers.rs.source_capture.rsfacade API unchanged for callers.Validation
cargo make fmt-rustcargo make fmt-rust-checkcargo make check-rustcargo make lint-vstylegit diff --checkcargo nextest run -p elf-service source_capture --all-features(4 passed)cargo make lint-rustcargo make test-rust(378 passed, 92 skipped)cargo make checkcargo make test-rust-integration(92 passed, 378 skipped; nextest reported 1 leaky with successful exit)cargo make check-trace-gate(passed twice after starting the trace-gate Postgres fixture)Review
docs/source_capture.rsas a strong low-risk modularization target.cargo make check-trace-gatesuccessfully in the main thread.