Split graph fact storage modules#277
Merged
Merged
Conversation
…ers into write, query, and supersession modules after strict validation.","authority":"manual"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elf-storagegraph fact helpers into normal Rust child modules:graph/fact/write.rsfor insert/upsert fact writes and evidence linksgraph/fact/query.rsfor active fact readsgraph/fact/supersession.rsfor active fact supersessiongraph/fact.rsas the private facade that re-exports the same four functions.elf_storage::graph::*surface throughgraph.rs.Validation
cargo check -p elf-storage --all-targets --all-featurescargo make fmt-rust-check && cargo make check-rust && cargo make lint-vstyle && git diff --checkcargo make lint-rust && cargo make test-rustcargo make checkcargo make test-rust-integrationelf-storage::graph_memoryand graph ingestion acceptance coverage.cargo make check-trace-gate127.0.0.1:5432.5432; passed.Review Notes
graph/fact.rshad independent write/query/supersession responsibilities and the existinggraph/predicate.rsalready uses the same facade pattern.