Skip to content

Split graph fact storage modules#277

Merged
yvette-carlisle merged 1 commit into
mainfrom
xy/split-graph-fact-modules
Jun 29, 2026
Merged

Split graph fact storage modules#277
yvette-carlisle merged 1 commit into
mainfrom
xy/split-graph-fact-modules

Conversation

@yvette-carlisle

Copy link
Copy Markdown
Member

Summary

  • Split elf-storage graph fact helpers into normal Rust child modules:
    • graph/fact/write.rs for insert/upsert fact writes and evidence links
    • graph/fact/query.rs for active fact reads
    • graph/fact/supersession.rs for active fact supersession
  • Kept graph/fact.rs as the private facade that re-exports the same four functions.
  • Preserved the existing public elf_storage::graph::* surface through graph.rs.

Validation

  • cargo check -p elf-storage --all-targets --all-features
  • cargo make fmt-rust-check && cargo make check-rust && cargo make lint-vstyle && git diff --check
  • cargo make lint-rust && cargo make test-rust
  • cargo make check
  • Docker-backed cargo make test-rust-integration
    • 92 passed, 370 skipped
    • Includes elf-storage::graph_memory and graph ingestion acceptance coverage.
  • cargo make check-trace-gate
    • Initial run used a non-default Postgres port while the fixture config points at 127.0.0.1:5432.
    • Re-ran with fixture-default Postgres on 5432; passed.

Review Notes

  • Scout selected this split because graph/fact.rs had independent write/query/supersession responsibilities and the existing graph/predicate.rs already uses the same facade pattern.
  • Skeptic found no blockers; the main risk was staging the new child modules with the facade, which this PR does.

…ers into write, query, and supersession modules after strict validation.","authority":"manual"}
@yvette-carlisle yvette-carlisle merged commit 8936bb4 into main Jun 29, 2026
12 checks passed
@yvette-carlisle yvette-carlisle deleted the xy/split-graph-fact-modules branch June 29, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant