Skip to content

Split consolidation service modules#259

Merged
yvette-carlisle merged 1 commit into
mainfrom
xy/split-consolidation-service
Jun 29, 2026
Merged

Split consolidation service modules#259
yvette-carlisle merged 1 commit into
mainfrom
xy/split-consolidation-service

Conversation

@yvette-carlisle

Copy link
Copy Markdown
Member

Summary

  • Split packages/elf-service/src/consolidation/service.rs into private runs, proposals, and review child modules.
  • Kept the public service surface as the same inherent ElfService methods.
  • Kept review-event hydration private to the consolidation service module tree and avoided include!, #[path], pub mod, or public re-exports for the new modules.

Validation

  • cargo make fmt-rust
  • cargo make check-rust
  • cargo make lint-vstyle
  • cargo make lint-rust
  • cargo make test-rust (370 passed / 92 skipped)
  • cargo make check (check-docs passed; nextest 370 passed / 92 skipped)
  • cargo make test-rust-integration (92 passed / 370 skipped)

Review Notes

  • Read-only scout selected this slice as lower-risk than SQL storage splits because the service responsibilities already separate into run, proposal, and review workflows.
  • Read-only skeptic found no code-level blocker in the staged diff; its initial validation objection was resolved with the repo-native validation above, including a post-review cargo make check-rust rerun.

@yvette-carlisle yvette-carlisle merged commit b026d3b into main Jun 29, 2026
12 checks passed
@yvette-carlisle yvette-carlisle deleted the xy/split-consolidation-service branch June 29, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant