Repository navigation
Conversation
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
Contributor
Author
|
Superseded by #245, merged into next as d19cdd3. This exact branch head is an ancestor of the independently reviewed #245 head e1e6da9; its inactive persistent-storage groundwork is included in that cumulative change. Live guest delivery, retirement and ordinary persistent SQL remain open under NC05. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary native persistent startup now refuses before provider connection or data effects until a root continuity witness is qualified. This stages the real retained-guest adapter and graph receipt v4 without enabling it: stable data ownership stays independent of compute generations, enrollment preserves pending before the original create, and compute cleanup never deletes persistent data.
The adapter holds the common guest mutation lease across absence, one create request, captured identity and owner publication. Docker's idempotent create endpoint alone supplies no exclusive ownership. Receipt v2 continues to reject even empty storage keys; receipt v3 remains a separate source-bearing family. Dead-publication recovery refuses receipt v4. Request budgets take the minimum of admission and explicit deadlines.
This draft is stacked on the inactive codec/enrollment foundations in #233 and #235, preserved at their original heads. The added metadata-aliasing counterexample shows why name, labels, birth and directory metadata cannot prove physical continuity after replacement. The root witness, provider integration and live SQL retention remain required; the source-pinned Bun/SQLite fixture currently qualifies lowering and fresh initializer scheduling only. It does not qualify PostgreSQL parity or full NC05 support.
Validation at ed249d0: independent source review; 17 persistence controls, 26 runtime controls (25 unchanged passes plus the corrected no-publication control), one request-deadline control and 25 lowerer/scheduler controls; default and all-feature all-target Clippy, Rust formatting; 124 protocol/model-registry tests qualified through the original round and affected reruns; strict CLI typecheck, changed-file lint, privacy, diff and owning commitlint. The separate TLC metadata-aliasing negative matched its exact witness. The historical 38-state enrollment result remains separate. Initial test/compile/lint failures are preserved. No provider, engine, SQL, helper execution or package build was performed. Exact-head hosted CI and current-base integration remain required.
Release intent: inactive native persistence groundwork; existing image-only defaults remain supported and persistent startup stays refused.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.