Repository navigation
Conversation
Support exact 0444, 0400 and 0600 modes on exclusive private file snapshots. Keep version 1 limited to 0444 and require protected members for version 2. Original source permissions remain unchanged; guest and retained-bind acceptance are separate gates.
Preserve the closed snapshot permission implementation and carry current canonical ownership, recovery, diagnostics and relay-test corrections. The prior port-absence failure remains historical test evidence.
Contributor
|
Found 2 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.svg)
Contributor
Author
|
Closing as source consolidation into #227 through #226. The feature commit and all production changes are preserved; the remaining test changes retain their assertions with formatting and an explicit outer allowance. Historical failures remain recorded. Retained-file acceptance remains open in #227, separate from new VM transport #250. Branch retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native private file delivery now preserves the requested 0444 config policy and supports protected 0400/0600 secret copies. Snapshot version 1 remains exactly 0444; version 2 must include a protected member and binds its exact saved mode. Unknown versions and permission drift refuse. Original source ownership, permissions and bytes are never changed to make delivery pass.
The current head normally merges next at 7c810a5. Nine of the ten original permission blobs remain byte-identical to 562e8c0; the owner test carries only canonical fixed-stage diagnostics. Current runtime/recovery code and the canonical owned-resource relay test oracle are retained. The historical 562 macOS port-absence failure is preserved; the test correction does not establish a product leak or crash fix.
Validation: original 562 focused/static qualification remains historical evidence. On this reconciliation, the affected owner case passed with diagnostics enabled (1 pass, 31 filtered, 4 assertions); CLI typecheck, nine-file lint, staged privacy, diff and commit-message checks passed. The qualified existing compiler was reused after checking unchanged owning inputs. No unchanged full suite, compiler/CLI build or real engine probe ran. Fresh exact-head CI remains required.
Actual guest UID/GID, granted and ungranted access, read-only writes, linked isolation and retained file adoption/lifecycle/recovery remain separate required gates. This PR grants no retained-file authority. Release intent: optional native snapshot permission support.