refactor(feed): drop empty auxiliary toolbar strip - #304
Conversation
The search/filter controls moved to the floating capsule, but the old toolbar container kept rendering an empty bordered 17px strip inside the section card whenever none of its content (refinement banner, checklist pill, busy indicator, presets) was visible. Gate the container behind a feedToolbarVisible derived so it only renders with actual content. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR removes an empty, bordered “auxiliary toolbar” strip that could render under the Feed hero after #303 moved search/filter controls into the floating capsule, by conditionally rendering the toolbar container only when it has visible content.
Changes:
- Introduces a new
$derivedboolean (feedToolbarVisible) to determine whether the auxiliary toolbar container should render. - Wraps the auxiliary toolbar markup in
{#if feedToolbarVisible}to prevent an empty container from leaving a stray bordered strip. - Keeps the existing busy live-region content tied to
feedChromeBusywithin the gated container.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a287fb6056
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…\nInclude runtime availability checks for lazy-loaded ProfileRefinementBanner and ProfileChecklistPill so the toolbar container only renders when it can contain content. Also keep the aria-live status region mounted (visually hidden) so screen readers reliably announce scan-start messages.\n\nfix(a11y): keep scan live region mounted for screen readers\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Follow-up to #303, which merged just before this commit landed on the feature branch.
Why
The search/filter controls moved to the floating glass capsule in #303, but the old toolbar container kept rendering inside the section card. When none of its remaining content (refinement banner, checklist pill, busy indicator, presets) is visible, it leaves an empty bordered 17px strip under the hero.
What
feedToolbarVisiblederived inFeedPage.svelteso it only renders when it actually carries contentfeedChromeBusyis true, which is part of the visibility conditionVerification
tsc --noEmitpassmanual partial results),filter dock, andARIA attributestests all passstrayCount: 0), section card renders only the hero blockCo-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com