chore: add package-lock.json with lockfileVersion 2 - #277
Open
joaquingatica wants to merge 1 commit into
Open
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository has had
package-lock=falsein.npmrcsince early on, so no lockfile was ever committed and every install resolved dependencies fresh. This pull request replaces that setting withlockfile-version=2and commits the generatedpackage-lock.json.Not having a lockfile makes installs non-reproducible in general and harder for tools/systems like Nix to include as part of builds (see issues adding
gulp-clitonixpkgsin NixOS/nixpkgs#528117).Added lockfile v2 rather than the latest v3 because of the desired support for Node v10+. Node 10 and 12 ship npm 6, which only understands the legacy
dependenciestree. A v2 lockfile carries both that tree and thepackagesmap npm 7+ prefers, so it stays readable everywhere the tests run. A v3 lockfile drops the legacy tree and would be ignored on the older versions.Also, adding a
package-lock.jsonshoudn't affect usages of this cli since they aren't published to NPM.