fix: swallow TCC.db SQL non-fatal warnings and log user friendly message - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #61
Details
When running
npx @guidepup/setup setuplocally it is generally expected that TCC.db updates will be denied due to SIP (generally a good thing!).For local development this isn't really a problem because when it comes to running Guidepup you will receive a system dialog prompting for permissions to automate applications (same as you get when using Playwright, or indeed many applications) which you can interact with to manually/JIT provide the required permissions.
Thus swallowing the stdout/stderr warnings that are emitted from the SQL command when it fails.
There is a risk that users will deny those permissions if they aren't aware why the dialog has appeared, so this change also adds a note log to explain the behaviour, linking off to docs for manual steps if preferred (or to rectify a denial of permissions from system prompt).
CheckList