Admiral AB test group renamed#15478
Merged
AnastasiiaBalenko merged 5 commits intomainfrom Mar 5, 2026
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
tomrf1
approved these changes
Mar 5, 2026
tomrf1
reviewed
Mar 5, 2026
| abTests?.isUserInTestGroup(testName, 'variant-detect') ?? false; | ||
| const variantName = isInVariantDetectGroup | ||
| ? 'variant-detect' | ||
| : 'variant-recovery'; |
…in the 'variant-detect' group
tomrf1
reviewed
Mar 5, 2026
ab-testing/config/abTests.ts
Outdated
| name: "growth-admiral-adblock-recovery", | ||
| description: "Test Admiral ad blocker detection and recovery modal", | ||
| name: "growth-admiral-adblock-detect", | ||
| description: "Test Admiral ad blocker detection", |
Member
There was a problem hiding this comment.
Suggested change
| description: "Test Admiral ad blocker detection", | |
| description: "Control group for Admiral ad blocker - runs the detection script but does not show the modal", |
tomrf1
approved these changes
Mar 5, 2026
tomrf1
added
run_chromatic
|
Seen on PROD (merged by @AnastasiiaBalenko 12 minutes and 15 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket link
What does this change?
Why?
After #15388, the test had only control.
Per the agreed Admiral behaviour, that setup did not match the intended rollout for this phase.
The expected behaviour is:
Admiral script should run for the experiment cohort
modal should not be shown
Using 'variant-detect' aligns the AB test definition and runtime check with that expected behaviour, so the script executes as intended without surfacing the modal.
Testing
Deployed on CODE env, confirmed the modal is shown up for users opt-out from abTest, and nodal is not shown up for users in test varaint-detect group
Screenshots