Hide old match nav and tabs when in redesign test group#15477
Open
jamesmockett wants to merge 1 commit intomainfrom
Open
Hide old match nav and tabs when in redesign test group#15477jamesmockett wants to merge 1 commit intomainfrom
jamesmockett wants to merge 1 commit intomainfrom
Conversation
Currently these are still rendered despite being replaced by the new match header component. As the corresponding grid areas do not exist when in the test group the old nav is rendered at the bottom of the page outside the main content area so appears partially off screen.
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
No longer renders the old match nav and tab components when in the redesign test group as these are replaced by the new match header component.
Currently the grid areas for these component are not created when in the test group, but the components are still rendered so they appear partially off-screen, outside of the main content area.
Screenshots