Draft
Conversation
cemms1
force-pushed
the
cemms1/add-mobile-sticky-test
branch
from
257103e to
e39a172
Compare
cemms1
force-pushed
the
cemms1/add-mobile-sticky-test
branch
2 times, most recently
from
7891396 to
90c8075
Compare
cemms1
force-pushed
the
cemms1/add-mobile-sticky-test
branch
from
90c8075 to
1b317e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a test for trialling the new rendering logic for launching the commercial mobile-sticky advert
Additionally installs a more recent version of
@guardian/libswhich adds to the commercial queue when the CMP has been dismissed. This is part of the logic needed for the testWhy?
We are adjusting the mobile-sticky ad launch conditions and want to test the performance of this against the existing logic.