Slim homepage AB test: Hide Deeply Read if not enough space#15466
Open
Slim homepage AB test: Hide Deeply Read if not enough space#15466
Conversation
domlander
added
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
domlander
changed the title
Georges-GNM
approved these changes
Mar 3, 2026
Contributor
Georges-GNM
left a comment
Georges-GNM
left a comment
There was a problem hiding this comment.
Struggled to test this but the code makes sense and this seems like a sensible safety feature, so looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Hide Deeply Read component if it is too large to fit in the space available.
Why?
In the Slim Homepage AB test, we add a Deeply Read (DR) component next to Features and More Features, and assume that there is enough space to insert the DR component. The DR component is absolutely positioned, so it will overflow subsequent content if there is not enough space.
We have assurances from stakeholders that there will always be enough content in these two containers to ensure there is enough space for the DR component. However, just to be extra safe, this PR adds a little bit of JS to measure the size of the content on the client and hides the DR component if it is too large.
Screenshots