Draft
Conversation
akinsola-guardian
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates @guardian/libs to 29.0.1 and makes the minimal code changes needed in Dotcom Rendering to keep Storybook stories and CMP boot logic consistent with the upgraded dependency.
Changes:
- Bump
@guardian/libsfrom27.1.0to29.0.1(package.json + lockfile). - Update Storybook stories to source
Article*enums from locallib/articleFormatinstead of@guardian/libs. - Update AUS CMP consent UUID cookie lookup to prefer
globalcmpUUIDwithccpaUUIDfallback.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pnpm-lock.yaml |
Updates the dependency graph to resolve @guardian/libs@29.0.1. |
dotcom-rendering/package.json |
Bumps the @guardian/libs dependency version. |
dotcom-rendering/src/components/MultiBylines.stories.tsx |
Switches enum imports away from @guardian/libs to local articleFormat. |
dotcom-rendering/src/components/Masthead/HighlightsCard.stories.tsx |
Same as above for masthead story formats. |
dotcom-rendering/src/client/bootCmp.ts |
Adjusts AUS consent UUID cookie selection logic. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
pnpm-lock.yaml:2407
@guardian/libs@29.0.1now declares a non-optional peer dependency ontslib^2.8.1, but this lockfile resolves it withtslib@2.6.2(see snapshots). This will produce an unmet peer dependency and may break installs/CI depending on peer-deps settings; consider bumpingtslibin the workspace (and regenerating the lockfile) or pinning a compatible@guardian/libsversion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Why?
Migrating Australian framework to GlobalCMP framework.