Open
Conversation
abeddow91
added
maintenance
github-actions
bot
removed
the
run_chromatic
abeddow91
force-pushed
the
ab/remove-dynamic-containers
branch
from
b1b7228 to
62980e1
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
domlander
approved these changes
Mar 4, 2026
Contributor
domlander
left a comment
domlander
left a comment
There was a problem hiding this comment.
Thanks for taking the time to remove this code. I think the following can also be removed:
- This comment sentence: https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/components/Card/components/CardLayout.tsx#L44
- These look to be removed in your frontend PR, so can probably also be removed for here: https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/frontend/feFront.ts#L43-L45. (see comment on L40-L41).
- A bunch of components in here are no longer used, e.g. Card50_Card50: https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/lib/dynamicSlices.tsx
Contributor
Author
Thanks for these @domlander! I've removed these references 👍 |
…s and modernise the stories.
dynamic slices need to be kept for the time being as they are used to render tag pages.
dynamic containers are replaced with containers of equivalent height.
… arguably not necessary, but since not all fronts will have secondary containers, we can save ourselves the processing.
…erences to dynamic slow in the comment
abeddow91
force-pushed
the
ab/remove-dynamic-containers
branch
from
3ce9196 to
b6706d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes code pertaining to dynamic containers. This includes dynamo cards which are only used in dynamic containers.
Why?
Dynamic containers have been deprecated and no longer exist.