docs: document _getDependencyData() directory parameter semantics#476
Merged
ruromero merged 3 commits intoguacsec:mainfrom Apr 15, 2026
Merged
docs: document _getDependencyData() directory parameter semantics#476ruromero merged 3 commits intoguacsec:mainfrom
ruromero merged 3 commits intoguacsec:mainfrom
Conversation
Add JSDoc to Base_pyproject._getDependencyData() explaining that manifestDir is the project directory and workspaceDir is the lock file directory. Documents when each should be used by lock-file-based vs non-lock-file providers. Implements TC-4102 Assisted-by: Claude Code
Collaborator
Author
Verification Report for TC-4102 (commit 9c2a34f)
Overall: WARNScope deviation is intentional — the author redirected documentation from CONVENTIONS.md to a JSDoc comment on This comment was AI-generated by sdlc-workflow/verify-pr v0.5.11. |
Strum355
reviewed
Apr 14, 2026
Remove caller reference, fix inaccurate fallback claim, and correct workspaceDir description to scope it to uv only (poetry ignores it). Implements TC-4102 Assisted-by: Claude Code
Implements TC-4102 Assisted-by: Claude Code
Strum355
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_getDependencyData()directory parameter semantics_createSbompasses bothmanifestDir(project directory) andworkspaceDir(lock file directory) to_getDependencyDataImplements TC-4102