Repository navigation
xds: check that resources are received from the right servers - #13146
Merged
Merged
Conversation
Ensure that handleResourceUpdate only applies resource updates, errors, or SotW absent notices to subscribers whose active control plane client matches the controlPlaneClient that received the ADS response. TAG=agy CONV=e27e4459-da3e-4c14-b2a1-2055f0b9b5d1
… ADS response Add sendDiscoveryResponse to XdsTestControlPlaneService and update isolatedResourceUpdates test in XdsClientFederationTest to directly send an unsolicited cross-authority ADS response on the wire, properly exercising the control plane isolation check in XdsClientImpl. TAG=agy CONV=e27e4459-da3e-4c14-b2a1-2055f0b9b5d1
shivaspeaks
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that handleResourceUpdate only applies resource updates, errors,
or SotW absent notices to subscribers whose active control plane client
matches the controlPlaneClient that received the ADS response.
Related similar fix in gRPC-core: grpc/grpc#43695