autosharding: implementation of picker and sliceMap - #13024
Open
shivaspeaks wants to merge 15 commits into
Open
Conversation
shivaspeaks
changed the title
…harding-part2-picker
shivaspeaks
marked this pull request as ready for review
September 3, 2026 02:48
sauravzg
reviewed
Sep 3, 2026
sauravzg
left a comment
sauravzg
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the source. A lot of comments are sent in a particular place but apply to the entire PR, so you may have to make changes at multiple places.
sauravzg
reviewed
Sep 4, 2026
| } | ||
| } | ||
|
|
||
| private boolean isPoolInFallback(List<Integer> indices) { |
Contributor
There was a problem hiding this comment.
I believe we may be able to optimise the precomputation , we iterate over all endpoints for all slices, which may not be optimal despite not being in the critical per prc path.
Member
Author
There was a problem hiding this comment.
Not sure what precomputation you mean.
I can think of one O(N) fast path for a flat endpoint list first.
Contributor
|
Please resolve the comments that you have fixed and add me again to take a look. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/grpc/proposal/pull/551/changes