xds: Remove newlines from XdsConfig.toString()#12838
Open
ejona86 wants to merge 1 commit into
Open
Conversation
The newlines can make logs really hard to read, as many log handling systems will split up each log statement by line. With the newlines, those singular log entries get split between multiple log entries which can make reading/processing it pretty ugly. When logging XdsConfig by itself, it isn't necessarily _that_ bad when XdsConfig is what you're actually trying to look at, but when XdsConfig is in the attributes of ResolvedAddresses it gets very distracting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newlines can make logs really hard to read, as many log handling systems will split up each log statement by line. With the newlines, those singular log entries get split between multiple log entries which can make reading/processing it pretty ugly.
When logging XdsConfig by itself, it isn't necessarily that bad when XdsConfig is what you're actually trying to look at, but when XdsConfig is in the attributes of ResolvedAddresses it gets very distracting.