core: Warn when server doesn't advertise grpc-accept-encoding#12622
Open
ani0x53 wants to merge 1 commit intogrpc:masterfrom
Open
core: Warn when server doesn't advertise grpc-accept-encoding#12622ani0x53 wants to merge 1 commit intogrpc:masterfrom
ani0x53 wants to merge 1 commit intogrpc:masterfrom
Conversation
|
|
ani0x53
force-pushed
the
fix/warn-missing-accept-encoding
branch
from
9841dec to
dcbd4aa
Compare
When the client sends compressed messages (grpc-encoding header set), but the server's response headers don't include grpc-accept-encoding, log a FINE-level warning. This helps diagnose compression compatibility issues between client and server. The warning is at FINE level to avoid disrupting existing systems while providing useful diagnostic information when needed. Fixes grpc#1804 Signed-off-by: anirudh83 <anirudh.bh@gmail.com>
ani0x53
force-pushed
the
fix/warn-missing-accept-encoding
branch
from
dcbd4aa to
50e29b3
Compare
| * | ||
| * @param messageEncoding the encoding name (e.g., "gzip"), or null for identity | ||
| */ | ||
| protected void setSentMessageEncoding(@Nullable String messageEncoding) { |
Contributor
There was a problem hiding this comment.
Instead of calling this directly from the unit test, make this private and add an overload constructor for BaseAbstractClientStream that takes a Metadata argument for headers to send. The currently used overload passes empty Metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the client sends compressed messages (grpc-encoding header set), but the server's response headers don't include grpc-accept-encoding, log a FINE-level warning. This helps diagnose compression compatibility issues between client and server.
The warning is at FINE level to avoid disrupting existing systems while providing useful diagnostic information when needed.
Fixes #1804