Keep Studio empty-events state honest - #1814
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Studio workbench dead-end when events array is empty
Keep Studio empty-events state honest
Sep 8, 2026
groupthinking
approved these changes
Sep 12, 2026
groupthinking
marked this pull request as ready for review
September 12, 2026 09:21
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🔍 PR Validation |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
🔴 E2E Test Results: FAILURE DETECTED
Test Output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Linked automatically by the system.
Outcome
Completed Studio runs with
events[] = []no longer imply transcript evidence when only pack identity exists. The empty Events rail remains honest while preserving the existing pack architecture/artifacts export path.Scope
studioEventsEmptyMessage()now branches on transcript presence instead of always mentioning transcript.OneLoopStudiopasseshasTranscriptinto the empty-state helper.Risk
hasTranscriptbranch instudioEventsEmptyMessage()and the caller wiring inOneLoopStudio.Verification
Head SHA:
130d78acd apps/web && npm test -- --run src/lib/__tests__/studio-pipeline-status.test.ts src/lib/__tests__/action-surface.test.ts src/store/__tests__/dashboard-store.test.tsProduction evidence
Not applicable for this change set: UI copy/state behavior only; no production receipt or deploy evidence was required for acceptance.
Agent handoff