Make Studio ?video= autostart one-shot under Strict Mode and document YouTube workflow - #1812
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Ensure Studio auto-start from ?video= runs once safely in Strict Mode
Make Studio Sep 8, 2026
?video= autostart one-shot under Strict Mode and document YouTube workflow
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
…eset, permanently suppressing auto-start for the last-started video id across remounts within an SPA session.
This commit fixes the issue reported at apps/web/src/lib/studio-handoff.ts:46
## Bug
`apps/web/src/lib/studio-handoff.ts` has a module-level global `strictModeAutoStartedVideoId` used to swallow React's Strict Mode double-mount:
```ts
let strictModeAutoStartedVideoId: string | null = null;
// ...
if (
input.startedKey.current === handoff.videoId ||
strictModeAutoStartedVideoId === handoff.videoId
) {
return 'already';
}
input.startedKey.current = handoff.videoId;
strictModeAutoStartedVideoId = handoff.videoId; // set, but never cleared
```
A grep confirms the global is only ever **set/compared, never reset**. The per-mount `autoStartedKey` `useRef` in `OneLoopStudio.tsx` resets to `null` on a fresh mount — which is what let the previous ref-only guard correctly re-trigger auto-start on a genuine remount. The new global lives for the entire module/page lifetime.
### Concrete failure trigger
1. User pastes video `A` on Home → navigates to `/studio?video=A`.
2. `OneLoopStudio` mounts, the auto-start effect runs, `runAnalysis(A)` fires, and the global is set to `A`.
3. Analysis fails (transient network error) **or** the user leaves Studio and later re-pastes the *same* video `A`.
4. `OneLoopStudio` remounts → `autoStartedKey.current` is a fresh `null`, but `strictModeAutoStartedVideoId` still equals `A`.
5. `applyStudioQueryAutoStart` returns `'already'`, so `start()` / `runAnalysis()` is **never called**. Studio opens but analysis silently never auto-starts.
This is a regression versus the prior ref-only guard, where a fresh mount always re-triggered auto-start for the same video.
## Fix
The guard is only needed to survive React's *synchronous* Strict Mode unmount→remount; it must be released once the component truly leaves the tree.
- Added `resetStudioQueryAutoStart()` to `studio-handoff.ts` that clears the module global.
- Added a dedicated `[]`-deps unmount effect in `OneLoopStudio.tsx` whose cleanup schedules the reset via `window.setTimeout(..., 0)`.
The deferral discriminates the two remount kinds:
- **Strict Mode** (dev): unmount + remount happen synchronously in the same tick, so the remount effect runs *before* the `setTimeout(0)` callback — the guard is still set → correctly returns `'already'`, no double-start. The reset then fires harmlessly.
- **Genuine navigation**: the user leaves Studio and returns later; the timeout has long since cleared the guard, so the fresh mount (with a fresh `null` ref) re-triggers auto-start.
Also added a regression test and an `afterEach(resetStudioQueryAutoStart)` to keep the suite deterministic.
## Rebase note
Rebased onto commit `cb84e8d`. The docs commit only reworded the comment above `StudioSearchParams`; the guard code and the absence of any reset site are unchanged, so the bug and fix stand as-is.
Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
Co-authored-by: groupthinking <garveyht@gmail.com>
github-actions
Bot
added
the
documentation
Contributor
🔍 PR Validation |
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
javascript
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
groupthinking
marked this pull request as ready for review
September 12, 2026 10:05
Contributor
🔴 E2E Test Results: FAILURE DETECTED
Test Output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Linked by automation.
Outcome
Studio now treats
?video=handoff as a one-shot trigger even across React Strict Mode remounts, preventing duplicate analysis starts./docs/apinow explicitly describes the Home → Studio → transcript/events → actions/output YouTube workflow.Scope
applyStudioQueryAutoStartnow guards on both caller ref state and a module-level video key so the same handoff video cannot double-start during Strict Mode remount behavior.alreadywith a singlestartcall./docs/api“Try it” section with explicit end-to-end workflow steps and one-shot Studio autostart behavior./studiohandoff/autostart and docs copy.Risk
apps/web/src/lib/studio-handoff.tsautostart guard and associated regression test.Verification
List exact automated and manual checks, tied to the current head SHA.
Production evidence
Not applicable for this PR: behavior and docs-only validation at app/test level; no production config or infrastructure change.
Agent handoff