feat(velocity): support static server discovery - #75
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98c8ccdf99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
12 tasks
12 tasks
|
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds strict static Velocity backend discovery through
GROUNDS_STATIC_SERVERSusingname=host:portentries. Static registrations are excluded from lobby selection and protected from Agones reconciliation through registration-identity ownership tracking.Fixes drain handling so only actual round roles (
gameandmatch) defer transfer. During automatic drain only, Java players on a static backend preserve that backend across the proxy move through a short-lived HMAC-signed transfer cookie. The source confirms an exact client echo before transfer; the target validates signature, TTL, and the currentstaticregistration. Missing, invalid, or timed-out cookies fall back to normal routing. Manual/regionand other proxy moves are unchanged.The existing Velocity image placeholders are removed only when their exact baked name/address pairs match; unrelated registrations and external same-name replacements are preserved.
Type of Change
Related Issues
Testing
Commands run:
Results: full build successful; 71 Velocity tests passed.
Checklist