Add PDB and probe support to MCP Helm chart#105
Open
kkhristenko51 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the rosetta-mcp-server Helm chart to support configurable Kubernetes health probes on the Deployment and an optional PodDisruptionBudget (PDB), and bumps the chart version to reflect the new functionality.
Changes:
- Add optional
livenessProbe,readinessProbe, andstartupProbevalues and render them into the Deployment when configured. - Add an optional PodDisruptionBudget template controlled by
podDisruptionBudget.*values (and gated by replica/minReplica count). - Bump chart version from
0.2.0to0.3.0.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| helm-charts/rosetta-mcp-server/values.yaml | Adds values for health probes and PDB configuration. |
| helm-charts/rosetta-mcp-server/templates/deployment.yaml | Renders optional container probes from values. |
| helm-charts/rosetta-mcp-server/templates/poddisruptionbudget.yaml | Adds a PDB resource template controlled by chart values. |
| helm-charts/rosetta-mcp-server/Chart.yaml | Version bump to 0.3.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kkhristenko51
commented
Jun 4, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Konstantin Khristenko <112936003+kkhristenko51@users.noreply.github.com>
Contributor
Rosetta Triage ReviewSummary: This PR extends the Findings:
Suggestions:
Automated triage by Rosetta agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PDB and startup/readiness/liveness probes support to MCP Helm chart
This PR extends the
rosetta-mcp-serverHelm chart to support configurable Kubernetes health probes on the Deployment and an optional PodDisruptionBudget (PDB), and bumps the chart version to reflect the new functionality.Changes:
livenessProbe,readinessProbe, andstartupProbevalues and render them into the Deployment when configured.podDisruptionBudget.*values (and gated by replica/minReplica count).0.2.0to0.3.0.