fix(ios): constrain releaseCapture to direct temporary files - #683
Open
OskarEichler wants to merge 2 commits into
Open
fix(ios): constrain releaseCapture to direct temporary files#683OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
OskarEichler
marked this pull request as ready for review
August 30, 2026 09:52
Author
|
Resolved the draft blocker by updating the existing native regression to assert the fixed behavior: prefix-only sibling paths are preserved. I reran the focused iOS Simulator XCTest target against the actual CocoaPods workspace; all 5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Constrain
releaseCaptureto regular files that are direct children of React Native's temporary directory.The implementation replaces raw string-prefix recursive removal with exact-root/direct-child validation and descriptor-relative, nonrecursive deletion. It rejects traversal, prefix siblings, directories, NULs, and symbolic-link escapes while preserving raw paths returned by
RCTTempFilePath.The native regression test now verifies that a file in a prefix-only sibling such as
ReactNativeImposteris preserved.Compatibility
Normal native-generated capture paths continue to release correctly. Arbitrary paths that merely share the temporary-root prefix, nested paths, directories, and symbolic links are no longer removed. No dependency or SDK version changes.
Verification
git diff --checkType: fix