feat!: add generic e2e support to check-store workflow#279
feat!: add generic e2e support to check-store workflow#279digitalrisedorset wants to merge 12 commits into
Conversation
|
So, what I'd like to see is that we can run this against a store even if that store doesn't have the e2e tests installed. So |
@damienwebdev I've pushed a follow-up commit. The workflow now:
I think this gets us much closer to the flow we discussed earlier today. Could you take another look when you have a moment? I suspect these changes might need tuning from where we are but this structure should be what we are aiming at. Once it works, I'll start 2 new activties:
|
|
@damienwebdev I've removed the guards you mentioned. I understand this is so that we can discover fully the E2E execution path and identify what still needs to be wired up. I imagine we may reinstate some of these guards once E2E tests are fully integrated. |
|
@Vinai asked two things:
|
@Vinai , @damienwebdev My thoughts were that MageOS would own the E2E tests and the execution environment (Node, Playwright version, dependency installation, etc.) would be a separate concern. |
…igger e2e tests steps
0b25c7f to
4bdd58b
Compare
|
Thanks for the continued work on this. E2e test code is now running. Before I re-review, I need to see a green run of the Here's how to run it on
Two notes:
Once you have a green run, link it here and I'll pick the review back up. |
thanks @damienwebdev for your support through this CI pipeline work. Today, I tracked down the issue preventing me from running the workflow in my fork. My fork was significantly behind upstream, so the Check Store workflow was not available. After syncing the fork, I was able to run Check Store Test successfully in my own fork as requested. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
check-store.yamlcurrently supports:There is currently no generic mechanism for executing optional store-defined E2E test suites within the reusable workflow.
Fixes: N/A
What is the new behavior?
Adds optional
e2e-testsupport tocheck-store.yaml.The workflow now:
package.jsonexistsnpm run test:e2eThis keeps E2E implementation details owned by the consuming store while allowing Mage-OS CI orchestration to execute generic Node-based E2E suites.
A minimal TypeScript-based E2E fixture was also added to validate the orchestration flow.
Does this PR introduce a breaking change?
Other information
This intentionally keeps the E2E contract lightweight and framework-agnostic for now.
The workflow orchestrates execution but does not enforce:
This allows consuming stores to define their own E2E implementation details while reusing the existing Mage-OS orchestration and Magento service bootstrapping.