-
Notifications
You must be signed in to change notification settings - Fork 66
Add a section about the HTTP protocol #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
martinbonnin
wants to merge
5
commits into
main
Choose a base branch
from
http-protocol
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3b87602
Add a note about the HTTP protocol
martinbonnin 4081cc5
Reword
martinbonnin 1b80e45
Reduce diff
martinbonnin 54fcc9b
Use consistent links
martinbonnin 6899648
make the HTTP section a bit easier to read and not just about compliance
martinbonnin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -117,6 +117,25 @@ interact with a _GraphQL service_. | |
| Note: GraphQL Subscriptions are beyond the scope of this specification at this | ||
| time. | ||
|
|
||
| # HTTP protocol | ||
|
|
||
| The details of the HTTP protocol used by GraphQL clients and servers are outside | ||
| this specification. | ||
|
|
||
| Where applicable, server and clients MUST comply with | ||
| [RFC7231](https://datatracker.ietf.org/doc/html/rfc7231) semantics. | ||
|
|
||
| In particular, "header", "status code", "body", "Accept", and "Content-Type" are | ||
| to be interpreted according to | ||
| [RFC7231](https://datatracker.ietf.org/doc/html/rfc7231). | ||
|
|
||
| A server MUST support at least one version of the HTTP message format, such as | ||
| [HTTP/1.1](https://datatracker.ietf.org/doc/html/rfc7230) or | ||
| [HTTP/2](https://datatracker.ietf.org/doc/html/rfc9113). | ||
|
Comment on lines
+133
to
+134
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note from wg: remove this, do not bind ourselves to this. |
||
|
|
||
| A server MAY support several versions of the HTTP message format for wider | ||
| compatibility. | ||
|
Comment on lines
+136
to
+137
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note from wg: We can also remove that sentence, it's redundent with the above. |
||
|
|
||
| # URL | ||
|
|
||
| A _server_ MUST enable GraphQL requests to one or more GraphQL schemas. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note from wg: we should wrap those in spec-md formatting.
cf https://github.com/graphql/graphql-over-http/blob/main/spec/metadata.json